Can't find DataModel stores #8

New issue

Closed

opened 2023-11-11 15:00:16 -06:00 by MrVoltz · 5 comments

MrVoltz commented 2023-11-11 15:00:16 -06:00 (Migrated from github.com)

Copy link

Hi, let me firstly thank you for this great mod. I've found an issue with the ProtoFlux Node browser that certain nodes can't be found, for example DataModelValueFieldStore<T>.

Hi, let me firstly thank you for this great mod. I've found an issue with the ProtoFlux Node browser that certain nodes can't be found, for example `DataModelValueFieldStore<T>`.  

BlueCyro commented 2023-11-12 10:08:54 -06:00 (Migrated from github.com)

Copy link

What version of ResoniteModLoader are you using, and what version of CherryPick are you using? I've checked this and can't replicate it on my side. Both the component and protoflux browsers show the data model stores just fine.

What version of ResoniteModLoader are you using, and what version of CherryPick are you using? I've checked this and can't replicate it on my side. Both the component and protoflux browsers show the data model stores just fine. 

Nytra commented 2023-11-12 19:17:18 -06:00 (Migrated from github.com)

Copy link

I have tried searching for DataModel and found that some don't appear in the ProtoFlux browser but do appear in the regular component selector. I think this is because there are actually some components with the same name in Uncategorized, for example DataModelValueFieldStore<T>, one of them exists in ProtoFlux/Runtimes/Execution/Nodes/Variables and the other exists in Uncategorized.

I have tried searching for `DataModel` and found that some don't appear in the ProtoFlux browser but do appear in the regular component selector. I think this is because there are actually some components with the same name in `Uncategorized`, for example `DataModelValueFieldStore<T>`, one of them exists in `ProtoFlux/Runtimes/Execution/Nodes/Variables` and the other exists in `Uncategorized`. 

MrVoltz commented 2023-11-13 01:02:50 -06:00 (Migrated from github.com)

Copy link

OnEngineInit is called right after ResoniteModLoader.dll is loaded. Because the Flux nodes are spread in multiple dlls, the node list CherryPick sees depends on the dll load order. I don't know why is it different on my machine, I have a lot of other mods and some additional libs installed. Delaying the initialization fixes the issue, but maybe I'll update the PR to move the scanning to its own method from the static block, because this is still a little bit janky.
Martin

13. listopadu 2023 2:17:28 SEČ, Nytra @.***> napsal:

I have tried searching for DataModel and found that some don't appear in the ProtoFlux browser but do appear in the regular component selector. I think this is because there are actuaally two components called DataModelValueFieldStore<T>, one of them exists in ProtoFlux/Runtimes/Execution/Nodes/Variables and the other exists in Uncategorized.

--
Reply to this email directly or view it on GitHub:
https://github.com/RileyGuy/CherryPick/issues/8#issuecomment-1807335304
You are receiving this because you authored the thread.

Message ID: @.***>

OnEngineInit is called right after ResoniteModLoader.dll is loaded. Because the Flux nodes are spread in multiple dlls, the node list CherryPick sees depends on the dll load order. I don't know why is it different on my machine, I have a lot of other mods and some additional libs installed. Delaying the initialization fixes the issue, but maybe I'll update the PR to move the scanning to its own method from the static block, because this is still a little bit janky. Martin 13. listopadu 2023 2:17:28 SEČ, Nytra ***@***.***> napsal: >I have tried searching for `DataModel` and found that some don't appear in the ProtoFlux browser but do appear in the regular component selector. I think this is because there are actuaally two components called `DataModelValueFieldStore<T>`, one of them exists in `ProtoFlux/Runtimes/Execution/Nodes/Variables` and the other exists in `Uncategorized`. > > > > >-- >Reply to this email directly or view it on GitHub: >https://github.com/RileyGuy/CherryPick/issues/8#issuecomment-1807335304 >You are receiving this because you authored the thread. > >Message ID: ***@***.***>

BlueCyro commented 2023-11-13 20:04:27 -06:00 (Migrated from github.com)

Copy link

This evidently does not appear to fix the problem, looking into other solutions.

This evidently does not appear to fix the problem, looking into other solutions.

BlueCyro commented 2023-11-13 20:21:49 -06:00 (Migrated from github.com)

Copy link

Fixed in f3d753a

Fixed in [f3d753a](https://github.com/RileyGuy/CherryPick/commit/f3d753a42d26e245be33a0792827c1df2ce636ef)

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

1.2.0

1.1.2

1.1.1

1.1.0

1.0.7

1.0.6

1.0.5

1.0.4

1.0.3

1.0.2

1.0.1

1.0.0

Labels

Clear labels   

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

bug

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cyro/CherryPick#8

No description provided.